This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Pointslicepool size classes #1913
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) save memory by not using large slices when we only need small ones In particular, fix #1912 2) use a default size that corresponds to a capacity that append() actually uses (I believe a size of 800 gets rounded up by make)
e.g. in docker-dev with 1s precision 2days means 172800 points. This is *before* maxdatapoints runtime consolidation, so we may as well accommodate it with some special size classes this makes sure our large slices won't be taken up by smaller (4k) requests
replay
reviewed
Oct 1, 2020
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been wanting to do this for years, and finally got an excuse (#1912) to do it.
didn't do scientific testing / memory comparisons, but docker-dev seems to work fine, and intuitively this should be fine (at the worst case, consume no more memory than before, but typically i would expect lower memory use)
I will say that we could probably make it more clever, but it's a start... ? what do you think?